Add more flexible setting for minHits into KF track finding#1150
Merged
Add more flexible setting for minHits into KF track finding#1150
Conversation
…ge data and MC steering files; add some more plots into TrackTruth classes and some mods for read/flexability
Contributor
|
This looks like a pretty standard change; I wonder if you retained all the plots in the TruthTrack processor, but the logic looks sound (and I am already running it so I know it isn't breaking things for sure). |
rodwyer100
approved these changes
Sep 30, 2025
mgignac
approved these changes
Sep 30, 2025
Collaborator
mgignac
left a comment
mgignac
left a comment
There was a problem hiding this comment.
Looks good to me... approving!
My only comment, which doesn't need to hold this up, is whether the configuration level changes should go into a pass4 steering file, so we preserve the behavior of our last pass and mark these changes for the upcoming pass?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes issue #1149